fix issues #172 create opencode stub file confuse user#173
fix issues #172 create opencode stub file confuse user#173caiqinghua wants to merge 4 commits intodifferent-ai:devfrom
Conversation
caiqinghua
commented
Jan 21, 2026
- there is no opencode
- pnpm dev error
- install opencode
- always error
|
Tried to repro locally from a fresh worktree. With PATH stripped of opencode, fails before build.rs runs because node_modules/tauri aren’t installed in this environment, so I couldn’t fully validate runtime behavior yet. Reviewing the change set, I’d like a couple adjustments before merge:
Let me know if you want me to wire up a clean release config + build wrapper; I can take it from here. |
|
Follow-up (previous comment got garbled by shell quoting). Tried to repro locally from a fresh worktree. With PATH stripped of opencode, pnpm -C packages/desktop dev fails before build.rs runs because node_modules/tauri aren't installed in this environment, so I couldn't fully validate runtime behavior yet. Reviewing the change set, I'd like a couple adjustments before merge:
Let me know if you want me to wire up a clean release config + build wrapper; I can take it from here. |
|
@benjaminshafii Yes, keeping tauri.conf.json immutable is better design. We should only remove create_debug_stub() to avoid confusion. |
|
Repro update: on this PR branch, with PATH excluding opencode but including cargo (~/.cargo/bin), I still think we should avoid in-place tauri.conf.json edits for release builds (same notes as before). If you want me to wire up a release-only config or safer wrapper, I can do it. |
|
Yes, agree. I have removed tauri.conf.json edits. |
|
@benjaminshafii ben, is there any other problem? |
|
Automated message: removing the debug stub is the right direction, but this now hard‑fails Suggestion: only hard error in release builds; in dev log a warning and continue with PATH mode. Also this PR is currently CONFLICTING with |